-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Allow direct linking to self-registering courses
#6318
Conversation
…be more close together
…registration page
f7ca05f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-aprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested additional steps on TS1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested additional steps for online courses on TS2. Works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again on ts1, also with the additional testing steps. Works as expected.
Development
: Allow direct linking to self-registering coursesGeneral
: Allow direct linking to self-registering courses
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
This PR implements the suggested change from #6171.
In short, it provides a way to link to self-registration course even if students are not yet registered. Previously, Artemis would show an error message. Now, this PR provides a registration page.
Description
/api/courses/{courseId}/for-dashboard
endpoint in case of an authentication error: If the user could self-register, but is not registered yet, this endpoint now 302-redirects to/api/courses/{courseId}/for-registration
./api/courses/{courseId}/for-registration
, which returns reduced information about the course. The endpoint is only accessible for students (and higher roles) who are allowed to self-register in the respective course. The endpoint redirects to/api/courses/{courseId}/for-dashboard
if the user is already registered.CourseService
and more thoroughly tested./courses/{courseId}
and/courses/{courseId}/*
to/courses/{courseId}/register
, if the user can register, but is not yet registered./courses/{courseId}/register
to/courses/{courseId}
, if the user is already registered.Steps for Testing
Prerequisites:
Suggestion: Use course with ID
117
"6.0 Testing Session Course 1" on TS1 and your personal TUM login to test. Usually, the course should have self-registration enabled and you probably are not registered with your personal login yet.Register
button on the page.New Testing Steps: Online Courses
Prerequisites:
Online Course
checkmark is checked in theEdit
configuration of the course (also disables theSelf-Registration
checkbox).Steps:
artemisUrl/courses/<your-course-id>
(e.g. https://artemis-test2.artemis.in.tum.de/courses/8563).Development
: Course access authorization alert sometimes appears twice #6382, which is not part of this PR.artemisUrl/courses/<your-course-id>/register
(e.g. https://artemis-test2.artemis.in.tum.de/courses/8563/register).Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
Registration for course with prerequisites: