-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assessment:
Visualize generic and manual feedback separately
#191
Conversation
General:
Generic and manual feedback separation in assessment mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
Nice work @imstreetspirit
Approve 👍
Ps. Left some comments regarding translation strings.
General:
Generic and manual feedback separation in assessment modeAssessments:
Visualize generic and manual feedback separately
Assessments:
Visualize generic and manual feedback separatelyAssessment:
Visualize generic and manual feedback separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the functionality of the corresponding Artemis PR in the context of modeling exercises. Therefore I also approve the functionality of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested the functionality of the corresponding Artemis PR in the context of modeling exercises. Approving this PR as well.
Checklist
Motivation and Context
Currently when the grading instructions is associated with the feedback element, we duplicate the feedback of the instruction in the feedback table. To avoid this duplication, we won't apply grading instruction into feedback element anymore. We will show feedback that comes from grading instruction and the manually written feedback separately in the feedback editor. Therefore, we used Feedback label of the editors.
Description
Steps for Testing
Will be tested with corresponding Artemis PR
Tutor/Instructor Steps
1.Create new modeling exercise, add structured grading instructions(drag&drop element)
2.Set due date after 4-5 min later
3.Publish exercise and login as a student
6. In assessment period, find the submission you submitted, start to assess
7. Assess UML element(class/attribute/method) in the editor:
7a. add some text manually, before start to type sth, placeholder should be "Enter your feedback here...". you should see only Feedback label.
7b. assess another UML element drag and drop the grading instruction into inline feedback area from instruction panel on the right, placeholder should be changed to "Enter your additional feedback here...". Near to the feedback label, you should see help icon, hover it. Tooltip message should be understandable from the assessor. We wont set the textarea with the feedback of the grading instruction. Next to the help icon, you should see feedback of grading instruction. You can not edit this text. Add some feedback into text area.
8. save your assessment.
Screenshots
Test Coverage
assessment-section.tsx 94.03%