Fix typo in #include <WiFiUdp.h> & increasing turns per kWh limit #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kes 600 turns per KWh.
|
Hi again. I bumped into the next issue which is my (very old) meter making 600 revolutions per kWh. Requiring me to increase the limit.
I picked 800 to be on the safe side, but 1000 might be more appropriate. |
jellekaufmann
changed the title
|
Thanks for fixing the typo (i'm using a MacBook by the way) and adjusting the upper limit for turns/kwh. I actually did a quick google image search looking for small meters: 600 seems to be the maximum. 800 as upper limit should be OK. Could you please bump the version to 221 in platform.ini and config.h, then I can merge you PR. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed a typo in influx.h that caused compilation to fail with a no such file or directory error.
It's a bit weird that I'm the first to run into this problem. This probably has something to do with how different operating systems handle case sensitivity in file names...
Jelle