Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse Interactions #26

Merged
4 commits merged into from
Apr 29, 2022
Merged

Mouse Interactions #26

4 commits merged into from
Apr 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2022

New feature description

  • Upgraded Babylon.js to 5.2.0 in order to use the new zoomToMouseLocation feature on the ArcRotateCamera
  • Updated the camera to orbit around the model even after zooming or panning

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

https://www.loom.com/share/06f28618724541119513b9119ba09e39

@ghost ghost requested review from braustin20 and philharlow April 22, 2022 17:26
@braustin20
Copy link
Collaborator

braustin20 commented Apr 25, 2022

I'm having trouble compiling this locally. Getting an eslint error. Have you seen this? Perhaps try an npm run clean and then npm run setup to test.

If you aren't seeing this perhaps it's my local environment.

Html Webpack Plugin:
  Error: Child compilation failed:
  Must use import to load ES Module: /Users/braustin/Dev/product-viewer/packages  /viewer-demos/node_modules/react-scripts/node_modules/@eslint/eslintrc/univers  al.js
  require() of ES modules is not supported.
  require() of /Users/braustin/Dev/product-viewer/packages/viewer-demos/node_mod  ules/react-scripts/node_modules/@eslint/eslintrc/universal.js from /Users/brau  stin/Dev/product-viewer/packages/viewer-demos/node_modules/react-scripts/node_  modules/eslint/lib/linter/linter.js is an ES module file as it is a .js file w  hose nearest parent package.json contains "type": "module" which defines all .  js files in that package scope as ES modules.
  Instead rename universal.js to end in .cjs, change the requiring code to use i  mport(), or remove "type": "module" from /Users/braustin/Dev/product-viewer/pa  ckages/viewer-demos/node_modules/react-scripts/node_modules/@eslint/eslintrc/p  ackage.json.
  
  - child-compiler.js:169 
    [viewer-demos]/[html-webpack-plugin]/lib/child-compiler.js:169:18
  
  - Compiler.js:559 
    [viewer-demos]/[webpack]/lib/Compiler.js:559:11
  
  - Compiler.js:1129 
    [viewer-demos]/[webpack]/lib/Compiler.js:1129:17
  
  
  - task_queues.js:97 processTicksAndRejections
    internal/process/task_queues.js:97:5

@ghost
Copy link
Author

ghost commented Apr 26, 2022

I'm having trouble compiling this locally. Getting an eslint error. Have you seen this? Perhaps try an npm run clean and then npm run setup to test.

If you aren't seeing this perhaps it's my local environment.

Html Webpack Plugin:
  Error: Child compilation failed:
  Must use import to load ES Module: /Users/braustin/Dev/product-viewer/packages  /viewer-demos/node_modules/react-scripts/node_modules/@eslint/eslintrc/univers  al.js
  require() of ES modules is not supported.
  require() of /Users/braustin/Dev/product-viewer/packages/viewer-demos/node_mod  ules/react-scripts/node_modules/@eslint/eslintrc/universal.js from /Users/brau  stin/Dev/product-viewer/packages/viewer-demos/node_modules/react-scripts/node_  modules/eslint/lib/linter/linter.js is an ES module file as it is a .js file w  hose nearest parent package.json contains "type": "module" which defines all .  js files in that package scope as ES modules.
  Instead rename universal.js to end in .cjs, change the requiring code to use i  mport(), or remove "type": "module" from /Users/braustin/Dev/product-viewer/pa  ckages/viewer-demos/node_modules/react-scripts/node_modules/@eslint/eslintrc/p  ackage.json.
  
  - child-compiler.js:169 
    [viewer-demos]/[html-webpack-plugin]/lib/child-compiler.js:169:18
  
  - Compiler.js:559 
    [viewer-demos]/[webpack]/lib/Compiler.js:559:11
  
  - Compiler.js:1129 
    [viewer-demos]/[webpack]/lib/Compiler.js:1129:17
  
  
  - task_queues.js:97 processTicksAndRejections
    internal/process/task_queues.js:97:5

Odd.. are you running Node 12? I was able to clean, setup and build just fine..

> node -v       
v12.22.7

@braustin20
Copy link
Collaborator

I'm having trouble compiling this locally. Getting an eslint error. Have you seen this? Perhaps try an npm run clean and then npm run setup to test.
If you aren't seeing this perhaps it's my local environment.

Html Webpack Plugin:
  Error: Child compilation failed:
  Must use import to load ES Module: /Users/braustin/Dev/product-viewer/packages  /viewer-demos/node_modules/react-scripts/node_modules/@eslint/eslintrc/univers  al.js
  require() of ES modules is not supported.
  require() of /Users/braustin/Dev/product-viewer/packages/viewer-demos/node_mod  ules/react-scripts/node_modules/@eslint/eslintrc/universal.js from /Users/brau  stin/Dev/product-viewer/packages/viewer-demos/node_modules/react-scripts/node_  modules/eslint/lib/linter/linter.js is an ES module file as it is a .js file w  hose nearest parent package.json contains "type": "module" which defines all .  js files in that package scope as ES modules.
  Instead rename universal.js to end in .cjs, change the requiring code to use i  mport(), or remove "type": "module" from /Users/braustin/Dev/product-viewer/pa  ckages/viewer-demos/node_modules/react-scripts/node_modules/@eslint/eslintrc/p  ackage.json.
  
  - child-compiler.js:169 
    [viewer-demos]/[html-webpack-plugin]/lib/child-compiler.js:169:18
  
  - Compiler.js:559 
    [viewer-demos]/[webpack]/lib/Compiler.js:559:11
  
  - Compiler.js:1129 
    [viewer-demos]/[webpack]/lib/Compiler.js:1129:17
  
  
  - task_queues.js:97 processTicksAndRejections
    internal/process/task_queues.js:97:5

Odd.. are you running Node 12? I was able to clean, setup and build just fine..

> node -v       
v12.22.7

Ah yep it seems to happen on v12.16.2. I installed v12.22.7 using nvm and it worked. Went back to 12.16.2 and got the same error. Must be some updated dependency causing this.

@ghost ghost merged commit a5fbd29 into main Apr 29, 2022
@ghost ghost deleted the users/john-lowes/mouse branch April 29, 2022 17:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant