[bazel,dvsim] remove gen-binaries.py's reliance on meson_init.sh #12634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added
Priority:P1
cfrantz
approved these changes
May 12, 2022
cfrantz
approved these changes
May 12, 2022
timothytrippel
force-pushed
the
bazelify-otbn-utils
branch
3 times, most recently
from
ea2aa31
to
1d6e944
Compare
rswarbrick
reviewed
May 13, 2022
There was a problem hiding this comment.
I'd rather you hadn't done the first commit: the project hasn't standardised on a Python formatter and to my eyes the results are much uglier than what was there already!
It's not a big deal and it seems silly to have to re-do the second patch, so don't worry too much. But please could you avoid re-formatting perfectly reasonable looking code until there's a project-level agreement on Python formatters (yapf isn't the only contender, and I also think that Python is a language where it might be better to mandate PEP8 compliance with, say, flake8 and then just expect people to format their code sensibly on their own).
rswarbrick
reviewed
May 13, 2022
Meson will soon be removed from our project and replaced entirely with bazel (lowRISC#12449). This updates the the OTBN `gen-binaries.py` script to not rely on the presence of the `.env` file that was produced by the `meson_init.sh` script to provide locations to the RV32 toolchain. Instead, the `gen-binaries.py` script now uses environment variables to get the locations of the RV32 toolchain tools, which are populated via queries to bazel. This fixes lowRISC#12447. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
force-pushed
the
bazelify-otbn-utils
branch
from
1d6e944
to
ea9b55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meson will soon be removed from our project and replaced entirely with
bazel (#12449). This updates the the OTBN
gen-binaries.pyscript tonot rely on the presence of the
.envfile that was produced by themeson_init.shscript to provide locations to the RV32 toolchain.Instead, the
gen-binaries.pyscript now uses environment variables toget the locations of the RV32 toolchain tools, which are populated via
queries to bazel.
This fixes #12447.
Signed-off-by: Timothy Trippel [email protected]