Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel] Symbol visibility #12551

Closed
alphan opened this issue May 9, 2022 · 4 comments
Closed

[bazel] Symbol visibility #12551

alphan opened this issue May 9, 2022 · 4 comments
Assignees
@arunthomas
Labels
Component:Software Issue related to Software Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones SW:ROM ROM related issues Type:Task Tasks, to-do list.
Milestone
Discrete: M3

Comments

@alphan
Copy link
Contributor

alphan commented May 9, 2022

Visibility of global symbols in the ELF file built with bazel is DEFAULT, vs. HIDDEN when built with meson.

See this line and the readelf outputs here.
@alphan alphan added Component:Software Issue related to Software Priority:P1 Priority: high Type:Task Tasks, to-do list. SW:ROM ROM related issues labels May 9, 2022
@alphan alphan mentioned this issue May 9, 2022
Closed
@moidx moidx added this to the Project: M2 milestone Aug 26, 2022
@msfschaffner msfschaffner modified the milestones: Project: M2, Project: M3 Oct 14, 2022
@msfschaffner
Copy link
Contributor

@alphan is this still relevant?

@a-will
Copy link
Contributor

a-will commented Aug 9, 2023

And thank goodness for that! It's much easier to debug on the FPGA when we can load the ELF w/ symbols in gdb.

@msfschaffner
Copy link
Contributor

Ok to close this?

@msfschaffner msfschaffner added the Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
@a-will
Copy link
Contributor

a-will commented Oct 7, 2023

Yup, we build the ELF with debug symbols in bazel now.

@a-will a-will closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunthomas arunthomas

Labels
Component:Software Issue related to Software Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones SW:ROM ROM related issues Type:Task Tasks, to-do list.
Projects
None yet
Milestone
Discrete: M3
Development

No branches or pull requests
5 participants
@arunthomas @a-will @moidx @msfschaffner @alphan