Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Compare mask rom built by bazel with meson #12069

Closed
Tracked by #12449
alphan opened this issue Apr 12, 2022 · 4 comments
Closed
Tracked by #12449

[bazel] Compare mask rom built by bazel with meson #12069

alphan opened this issue Apr 12, 2022 · 4 comments
Assignees
Labels
Component:Software Issue related to Software Priority:P1 Priority: high SW:ROM ROM related issues Type:Task Tasks, to-do list.

Comments

@alphan
Copy link
Contributor

alphan commented Apr 12, 2022

Before we complete the transition from meson to bazel we should compare the mask roms built by bazel and meson. Some things that may be worth checking:

  • All unit (off-target) and functional (on-target) tests should run and pass.
  • Binary size.
  • Symbols.
  • Disassembly diff (spot checks).
  • CLI arguments to toolchain (if this is relatively easy to obtain and compare in a meaningful way).

cc @arunthomas

@arunthomas arunthomas added Component:Software Issue related to Software Priority:P0 Priority: critical Type:Task Tasks, to-do list. SW:ROM ROM related issues labels Apr 12, 2022
@alphan
Copy link
Contributor Author

alphan commented Apr 18, 2022

doc

@timothytrippel
Copy link
Contributor

@alphan can we close this now? (I remember you mentioning you got things worked out such that both images are the same now?)

@alphan
Copy link
Contributor Author

alphan commented May 9, 2022

@timothytrippel yes, the only blocking issue (a minor difference in size, independent of optimization flags) was fixed in #12451.

The last time I checked, bazel was running all tests ran by meson (+ 4 additional tests) and I also did a handful of spot checks in disassembly.

Also, the last time I checked, functests were run by systemtest. I guess we can check those when we deprecate it. PLMK if we should create a separate issue for this.

I created the following issues for optimization flags, symbol visibility, annotated disassembly, and warnings:

@alphan alphan closed this as completed May 9, 2022
@timothytrippel
Copy link
Contributor

sounds great, thanks @alphan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Software Issue related to Software Priority:P1 Priority: high SW:ROM ROM related issues Type:Task Tasks, to-do list.
Projects
None yet
Development

No branches or pull requests

4 participants