Plic inc support #133
Open
Plic inc support #133
+308
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disdi
force-pushed
the
plic_inc_support
branch
from
c57cdd1 to
ed9db92
Compare
rtl/system/ibex_demo_system.sv
Outdated
| @@ -71,6 +71,10 @@ module ibex_demo_system #( | |||
| parameter logic [31:0] SIM_CTRL_START = 32'h20000; | |||
| parameter logic [31:0] SIM_CTRL_MASK = ~(SIM_CTRL_SIZE-1); | |||
|
|
|||
| localparam logic [31:0] PLIC_SIZE = 4 * 1024; // 4 KiB | |||
| localparam logic [31:0] PLIC_START = 32'h80005000; | |||
There was a problem hiding this comment.
It's probably best to keep the 8000X000 addresses for those that are only 1 KiB in size. Maybe create it at 0x8010000?
There was a problem hiding this comment.
I corrected this in latest commit.
rtl/system/ibex_demo_system.sv
Outdated
| .irq_external_i(1'b0), | ||
| .irq_fast_i ({14'b0, uart_irq}), | ||
| .irq_external_i(irq_external), | ||
| .irq_fast_i (1'b0), |
There was a problem hiding this comment.
This should still be 15 bits right?
| @@ -494,6 +502,39 @@ module ibex_demo_system #( | |||
| assign ndmreset_req = 1'b0; | |||
| end | |||
|
|
|||
| assign irq_sources = { | |||
There was a problem hiding this comment.
Is irq_sources defined somewhere? If so what is its width?
rtl/system/plic.sv
Outdated
|
|
||
| assign rdata_o = reg_rdata; | ||
|
|
||
| endmodule |
rtl/system/ibex_demo_system.sv
Outdated
| @@ -71,6 +71,10 @@ module ibex_demo_system #( | |||
| parameter logic [31:0] SIM_CTRL_START = 32'h20000; | |||
| parameter logic [31:0] SIM_CTRL_MASK = ~(SIM_CTRL_SIZE-1); | |||
|
|
|||
| localparam logic [31:0] PLIC_SIZE = 4 * 1024; // 4 KiB | |||
There was a problem hiding this comment.
Is this enough? I thought this needed to be 64 MiB?
I am still not able to get UART interrupt working with PLIC. I think my sw driver needs some change.
LUTs increased from 6686 to 6790, FFs increased from 6279 to 6411. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PLIC interrupt controller as per RISC-V PLIC specs.