Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function style fixer #39

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Function style fixer #39

merged 4 commits into from
Jan 17, 2019

Conversation

f18m
Copy link
Contributor

@f18m f18m commented Jan 16, 2019

This PR is the first attempt to fix #32

lovesegfault
lovesegfault requested changes Jan 16, 2019
View reviewed changes
Copy link
Owner

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I think now, to implement 2) and detect the most used syntax for a default behavior we just have to count the regex matches per style in the whole file?

beautysh/beautysh.py Outdated Show resolved Hide resolved
beautysh/beautysh.py Outdated Show resolved Hide resolved
beautysh/beautysh.py Outdated Show resolved Hide resolved
beautysh/beautysh.py Show resolved Hide resolved
beautysh/beautysh.py Show resolved Hide resolved
beautysh/beautysh.py Show resolved Hide resolved
@f18m
Copy link
Contributor Author

f18m commented Jan 17, 2019

Looking good!

great!

I think now, to implement 2) and detect the most used syntax for a default behavior we just have to count the regex matches per style in the whole file?

yes right. To enable such behavior perhaps we could have a
--force-function-style=autodetect
option value?

@lovesegfault
Copy link
Owner

yes right. To enable such behavior perhaps we could have a
--force-function-style=autodetect
option value?

Agreed, but I'll leave that for a separate PR. This looks great! Thanks for your contributions!

@lovesegfault lovesegfault merged commit 69b1a2b into lovesegfault:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different bash function syntaxes are tolerated
2 participants
@f18m @lovesegfault