Skip to content

reject non-finite numbers in is.number #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 1 commit into from
Jun 23, 2026
Merged

reject non-finite numbers in is.number #4553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/is.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const string = (val) => typeof val === 'string' && val.length > 0;
* Is this value a real number?
* @private
*/
const number = (val) => typeof val === 'number' && !Number.isNaN(val);
const number = (val) => typeof val === 'number' && Number.isFinite(val);

/**
* Is this value an integer?
Expand Down
14 changes: 14 additions & 0 deletions test/unit/affine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,20 @@ suite('Affine transform', () => {
.affine([[4, 4], [4, 4]], { ody: 'invalid ody type' });
});
});
test('Non-finite idx offset', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg)
.affine([[4, 4], [4, 4]], { idx: Infinity });
});
});
test('Non-finite idy offset', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg)
.affine([[4, 4], [4, 4]], { idy: -Infinity });
});
});
test('Invalid interpolator', (t) => {
t.plan(1);
t.assert.throws(() => {
Expand Down