Skip to content

validate convolve kernel values are numbers #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 1 commit into from
Jun 18, 2026
Merged

validate convolve kernel values are numbers #4549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/operation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,8 @@ function convolve (kernel) {
if (!is.object(kernel) || !Array.isArray(kernel.kernel) ||
!is.integer(kernel.width) || !is.integer(kernel.height) ||
!is.inRange(kernel.width, 3, 1001) || !is.inRange(kernel.height, 3, 1001) ||
kernel.height * kernel.width !== kernel.kernel.length
kernel.height * kernel.width !== kernel.kernel.length ||
!kernel.kernel.every(is.number)
) {
// must pass in a kernel
throw new Error('Invalid convolution kernel');
Expand Down
20 changes: 20 additions & 0 deletions test/unit/convolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,25 @@ suite('Convolve', () => {
});
});
});
test('non-numeric kernel value', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg).convolve({
width: 3,
height: 3,
kernel: [1, 2, 3, 4, '5', 6, 7, 8, 9]
});
});
});
test('NaN kernel value', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg).convolve({
width: 3,
height: 3,
kernel: [1, 2, 3, 4, NaN, 6, 7, 8, 9]
});
});
});
});
});