Skip to content

bound dilate and erode width to avoid mask-size overflow #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 2 commits into from
Jun 17, 2026
Merged

bound dilate and erode width to avoid mask-size overflow #4548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
955ed3f
bound dilate and erode width to avoid mask-size overflow
metsw24-max Jun 17, 2026
7bae61c
raise dilate and erode width bound to 65536
metsw24-max Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/operation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,10 @@ function blur (options) {
function dilate (width) {
if (!is.defined(width)) {
this.options.dilateWidth = 1;
} else if (is.integer(width) && width > 0) {
} else if (is.integer(width) && is.inRange(width, 1, 65536)) {
this.options.dilateWidth = width;
} else {
throw is.invalidParameterError('dilate', 'positive integer', dilate);
throw is.invalidParameterError('width', 'integer between 1 and 65536', width);
}
return this;
}
Expand All @@ -447,10 +447,10 @@ function dilate (width) {
function erode (width) {
if (!is.defined(width)) {
this.options.erodeWidth = 1;
} else if (is.integer(width) && width > 0) {
} else if (is.integer(width) && is.inRange(width, 1, 65536)) {
this.options.erodeWidth = width;
} else {
throw is.invalidParameterError('erode', 'positive integer', erode);
throw is.invalidParameterError('width', 'integer between 1 and 65536', width);
}
return this;
}
Expand Down
7 changes: 7 additions & 0 deletions test/unit/dilate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,11 @@ suite('Dilate', () => {
sharp(fixtures.inputJpg).dilate(-1);
});
});

test('oversized dilation width is rejected', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg).dilate(2147483648);
});
});
});
7 changes: 7 additions & 0 deletions test/unit/erode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,11 @@ suite('Erode', () => {
sharp(fixtures.inputJpg).erode(-1);
});
});

test('oversized erosion width is rejected', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg).erode(2147483648);
});
});
});