Skip to content

validate recomb matrix entries are numbers #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 1 commit into from
Jun 15, 2026
Merged

validate recomb matrix entries are numbers #4545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/operation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,10 +862,13 @@ function recomb (inputMatrix) {
if (inputMatrix.length !== 3 && inputMatrix.length !== 4) {
throw is.invalidParameterError('inputMatrix', '3x3 or 4x4 array', inputMatrix.length);
}
const recombMatrix = inputMatrix.flat().map(Number);
const recombMatrix = inputMatrix.flat();
if (recombMatrix.length !== 9 && recombMatrix.length !== 16) {
throw is.invalidParameterError('inputMatrix', 'cardinality of 9 or 16', recombMatrix.length);
}
if (!recombMatrix.every(is.number)) {
throw is.invalidParameterError('inputMatrix', 'array of numbers', recombMatrix);
}
this.options.recombMatrix = recombMatrix;
return this;
}
Expand Down
6 changes: 6 additions & 0 deletions test/unit/recomb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,11 @@ suite('Recomb', () => {
sharp(fixtures.inputJpg).recomb([[1, 2, 3, 4], [5, 6, 7, 8]]);
});
});
test('non-numeric entries', (t) => {
t.plan(1);
t.assert.throws(() => {
sharp(fixtures.inputJpg).recomb([['a', 'b', 'c'], [1, 2, 3], [4, 5, 6]]);
});
});
});
});