Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http1_title_case_headers support to reqwest http client #247

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

shahar3012
Copy link
Contributor

Some HTTP server implementations don't follow HTTP 1.1 standard:

HTTP header fields, which include general-header (section 4.5), request-header (section 5.3), response-header (section 6.2), and entity-header (section 7.1) fields, follow the same generic format as that given in Section 3.1 of RFC 822 [9]. Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

Reqwest default behavior is lowercase headers, which might result in errors from some HTTP servers that don't follow HTTP 1.1 standard.
To avoid it, this PR uses the http1_title_case_headers function to add support for case-sensitive HTTP headers.

@lovasoa lovasoa merged commit 9e63d16 into lovasoa:master Jul 12, 2024
0 of 3 checks passed
@lovasoa
Copy link
Owner

lovasoa commented Jul 12, 2024

thanks !

@lovasoa
Copy link
Owner

lovasoa commented Jul 13, 2024

published as v2.12.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants