-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️⚠️⚠️ Please read this before create a pull request ⚠️⚠️⚠️ #1349
Conversation
It's painful to see you receive hate after all you have done, but it's also painful to see a good community fade away because we cannot move forward. The project has grown so much in popularity, people will want to add features that are more niche and at some point it doesn't make sense for 1 guy to have to test everything anyway! If you think stability is a problem maybe we can run beta / rc releases, and if you think going through issues is too much a chore we can add people to help close duplicates, etc. But I really believe that bringing more people onboard to help is the way to keep the project healthy. |
@louislam as I recommended in my email, you should give write access to some trusted contributors so they can help you. You don't need to be a one man army, it's okay to get some help from the community :) |
This is a good idea, so that normal users could participate as well. |
Please do it! It would be great to see all those pull requests in uptime kuma without you spending all your free time on it. |
Yeah, you should there are alot off people that can help just look the prs, the project is a bit frozen right now and misses some features, like an incident system even that there is an pr about it |
@louislam In case you want to make Uptime Kuma a community project, I've reserved this group URL just for that: https://github.com/uptime-kuma Then you could move this project to https://github.com/uptime-kuma/uptime-kuma and assign members. What do you think about it? And who else would be interested in this? |
Great idea |
@louislam @Saibamen @karelkryda @chakflying @Ponkhy @ivanbratovic @iomataani @andreasbrett @bertyhell @gaby @philippdormann @MrEddX @zsxeee @sovushik @AnnAngela @patrickhafner @MarcHagen @LLeny @justSem @Computroniks @ColdThunder11 @jimyhuang @OidaTiftla @raphaelbernhart @c0derMo @marcules @trogper @jensneuber @jcvincenti @xjoker @nixnotcastey @cmandesign @cch-aecomhk @dhfhfk @BCsabaEngine @jtagcat @Lrss @pemassi @tarun7singh @csabibela @Rayzggz The reason why I referenced youI've noticed that you've contributed in some way to the success of this project. That's awesome, thank you so much for that! All Uptime Kuma users highly appreciate your time and dedication you've put into this project so far. The problemThe progress of this project has slowed down quite a bit lately. There are several reasons for this, but primarily because currently the maintenance effort of this project has to be done by only one person: @louislam. And this has led to Louis Lam feeling increasingly pressured and also that he has become tired of reviewing and merging all the pull requests (as mentioned in his statement on Reddit). One possible solutionIn my comment a week ago, I asked Louis Lam to make Uptime Kuma a community project. I reserved the group name uptime-kuma for this. However, to make this possible, we need several volunteers who would like to be maintainers of Uptime Kuma as a community project. Would any of you be interested in this role? Or does anyone have a better suggestion on how we can handle all the outstanding pull requests and the future of this great project? |
Greetings! I fully support the proposal, but the last word and decision, alas, is not mine. I contribute as a localizer into Russian, and the promotion of this script among Russian developers. |
I think the biggest problem is the lack of project automation. Like GitHub actions for code formatting tests and functional tests. Even bots that help sorting issues and making sure users create issues according to issue template can help release some pressure. I think a uptime-kuma community project is a create solution. Creating a slack group or use GitHub (private?) repo to maybe communicate about thing between volunteers is also not a bad idea. What we maybe also need is just e definition of what the "product" should be and how it should behave. At some point, like @louislam said, we can and will break things. Maybe look at the source code and see if splitting up / refactoring for a bigger codebase is something we need in the future. I'm "hate" to see project die because it's not maintainable.
Is never the right solution! |
As others have said, it does seem like a good idea to split up the workload between more than one person. Well done to @louislam so far for working on this project on their own. Of course, I would love to help in any way that is seen fit. As for a the suggestion about some form of chat/discussion by @MarcHagen, perhaps Gitter would also be an option as it offers both public and private communities whilst being totally free. |
Hi, Of course, I would like to participate in the future of this project and I must say that I like your idea. Of course, it all depends on Louislam, but at the moment I understand that he feels under pressure. I agree that automating some actions would certainly make the job easier and probably improve efficiency. Let me know if I can help in any way. Tl;drI will be happy to participate in maintaining uptime-kuma. |
I think we all agree that splitting up the workload of maintaining would/should be the way moving forward. This isn't an issue "exclusive" to louislam, I think none of us would be able to maintain a project grown to this size all by themselves. I support the previous ideas here, like moving the project to a more community-maintained repo, increasing the automation level, adding more contributors and communication, etc, and would be happy to help with that. Afterall, collaboration is one of the great things open-source software allows. But in the end, this is still @louislam's choice. Tl;dr: (@mamiu)I like the idea of moving the project to a more community-maintained repo, and would gladly help maintaining it, but in the end, it's louislam's choice. |
Hi, I also agree with @MarcHagen in the sense that Uptime-kuma would benefit from a proper definition of what it should be, and what it should not be. This could prevent the project from growing out of proportions and maintain it's quality. For communications/orchestration I would be willing to donate server resources if there's anything that would help the project, if that would prevent the project from having to pay for things that we could host ourselves. (I do host it in a datacenter though, so it's reliable :) ) |
Heyo, Of course i'd love to contribute and help to main this this project more! |
Hey, I've worked on small parts of the project earlier. |
I agree that automated tools will make this project better in many ways. And I also support @mamiu 's opinion about making Uptime Kuma a community project, and would gladly help maintaining it, but in the end, it's @louislam 's decision, I really respect his unparalleled contribution to this project. English isn't my primary language, I'm not good at it. All I want to say is that, @louislam makes a great, excellent |
@MarcHagen Not only the lack of automation (bots, etc), but the lack of an open-source CI process as I pointed out back in August, 2021 #740 @mamiu I'd be more than happy to help! I was already in the process of creating a fork under a different name and merging some of the big PR's, and going from there. |
I respect how much effort @louislam has put into this project. It would be great if I can contribute and help as a volunteer. |
@louislam did lots of efforts for this project but still has too many issues and PRs piled up. I'm afraid to commit changes in this situation, too many potential conflicts, especially only one person to handle this. It can not be avoided when maintaining a project alone. Really needs more maintainers to do that. BTW, we can close "help" issues that have been responded. (Move to Discussion?) |
I carefully read the comment from @louislam above. I can totally understand the pressure from pull request, and sometimes it's different with personal plan. I just want to say: it's totally fine with me. Whatever the project is more personal or more community. I can always help as long as it's open source and I have time to spent on it. For example, my personal pull request is more likely an idea or suggestion. It's totally fine to accept or reject. It's not a big deal to me (I can use my folked version for now). I think it's positive suggestion that @mamiu said to change the project ownership to an github organization. This may solve current situation. But I need to say, changing ownership is not the only option. Louis can always have his personal version of this project, and community may have another one. That's also not a big deal. Open source will sustain when time passed. Thanks for everyone especially the @louislam made this great project and made this open. I will always happy to join in whatever the decision. Just for reference: examples which project owner have different plan:
|
While this is the nature of opensource (when licenses allow) it’s not always practical to just fork it. statping and statping-ng are a good example that people still get confused and frustrated over. Let we all please try to first keep just one version? Give it some time, it’s not that the project is dead… |
This, please don't fork while we still have a chance to keep a single project. |
I think it doesn't really make sense to talk about that without louislam
telling us what he thinks about it.
|
I would say it's more about discussing possible solutions than deciding behind his back. Of course, everything depends on him, but for myself I can say that I am willing to help. |
Just here to let you know that I would be happy to help. I think this project has so much potential and would love see it thrive. |
@louislam Thoughts on this? |
Thanks everyone for your help! I think @mamiu's approach is good ultimately, but I also think it might be a too big step, because trust might take some time to build. It would be hard for me to judge who should be added to the group. Also at this moment, Uptime Kuma development is just my hobby in my free time. Working as a group of people sounds too serious for me. With the current approach, the relationship would be less complicated in my opinion. Too be clear, Uptime Kuma was/is not actually maintained by one person in the past. Many active users such as @chakflying @Ponkhy @Saibamen @gaby (More...) are here helping the project. And I think the main issue is that pull requests are required a lot of test. I try to list some tasks here if you want a clear path to help or to test this project. (From easy to expert) GeneralTest as a Normal UserAs @chakflying suggested, now I release beta release for testing purpose. You just need to play Uptime Kuma as a user, see if any unexpectedly behaviors. The docker tag
Helping other Uptime Kuma usersThey will be on:
Test Pull RequestI will mark pull requests into Milestones if they are going to be merged, so you can focus on these pull requests too. Pull Request - Code ReviewRead the source code (File changed) on GitHub, see if the pull request is including some inappropriate code or formatting issues. Pull Request - Testing as a Normal UserCheckout a pull request and test the feature as a normal user. Check if it is working fine or any potential breaking changes. Pull Request - Testing as a HackerCheckout a pull request and try to break it. Create a new Pull RequestIf you have some ideas that really want to implement into Uptime Kuma, be sure to open an empty draft pull request with description, so we could have a discussion first. |
We understand you may be busy, but the point stands: progress on the repository is slow. If this isn't addressed quickly, development will drive to a halt and people will just fork the repository and maintain it on their own, which is less than ideal. People have offered to help develop this as a community. It's sad to say this, but uptime kuma is no longer a toy project that one person can develop in their free time. Something needs to change. |
@louislam Thanks a lot for taking the time to respond. All I'm trying to say is: We've a problem... and please don't just bandage it. I know I've done it before but give me another try. Current problem:
Possible solutions:
If anyone has other / better suggestions, just add them here as comments. |
A lot of these issues would be fixed with automated tests. All we need is a PR setting up a ci/cd flow to run the end-to-end tests automatically on every PR/beta release. And then we would need to write out what scenarios to test. Maybe a google doc where everyone can just add to the same list of scenarios until every little features is checked. Then we divvy up scenarios to developers who want to help create these tests. After that @louislam can be reasonably sure new PR's do not break any existing features. It moves a lot of the checking work to the developer making the PR, instead of @louislam We'll just have to include an end-to-end testing requirement for all future feature PR's. This would solve these issues:
|
About Cypress: I don't recommend it (yet) for SPA application because of this bug: cypress-io/cypress#7306 |
Ha, because of one bug! That's not the only painful issue with cypress. Here are the issues from the top of my head that affect every single work day for me:
I've been waiting for a year for these issues to resolve. It has not improved even a single bit… or maybe it did? I can't upgrade to a newer version of cypress (because of the still unresolved major performance regression) so I can't even tell!!! At the time, I've made a good decision to write e2e tests, but unfortunately I've made a horrible mistake of using Cypress. My current understanding is that Playwright is the way to go, and that you should avoid cypress at all cost. P.S. I actually don't know about Uptime Kuma, I just found a backlink from a comment that I found interesting, so my rant mode got activated. |
We are clearing up our old Pull Requests and yours has been open for 3 months with no activity. Remove stale label or comment or this will be closed in 2 days. |
(Updated 2022-04-24) Pull requests will be welcome again, but since I don't want to waste your time, be sure to create empty draft pull request, so we can discuss first.
✅ Accept:
More details:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md