Enables warnings by default for all compiles of the PlayRho library #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
Closed
louis-langholtz
force-pushed
the
add_warns_to_cmake_library_compiles
branch
from
ba323ca
to
2751939
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
louis-langholtz
force-pushed
the
add_warns_to_cmake_library_compiles
branch
from
2751939
to
aee5083
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
louis-langholtz
force-pushed
the
add_warns_to_cmake_library_compiles
branch
from
aee5083
to
8c65bf9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
louis-langholtz
force-pushed
the
add_warns_to_cmake_library_compiles
branch
from
8c65bf9
to
a853a2e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
I had these enabled in my development environments but had forgotten to add these to CMake. Thanks go to GitHub user "titofra" for pointing out that these were missing from CMake in their PR, #484. Also, this increases the genericity of the GetModuloNext math function and ensures it returns the intended value.
louis-langholtz
force-pushed
the
add_warns_to_cmake_library_compiles
branch
from
a853a2e
to
c7e616a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
I had these enabled in my development environments but had forgotten to add these to CMake. Thanks go to GitHub user "titofra" for pointing out that these were missing from CMake in their PR, #484.
Impacts/Risks of These Changes?
Cleaner builds - in terms of compiler reported warnings/errors - by users including the PlayRho library.
Where should a reviewer start?
The compile logs of the CI workflows.
How should this be tested?
Noticing that no warnings/errors are reported - after possibly addressing any that may now show up.
Related Pull Requests