Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on using the logger #1196

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Update documentation on using the logger #1196

merged 1 commit into from
Oct 26, 2020

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Oct 26, 2020

Description

The docs on logging are slightly out of date. Faraday::Logging::Formatter is the correct class to subclass.

@tijmenb
Update documentation on using the logger
ff2b8c7 
`Faraday::Logging::Formatter` is the correct class to subclass.
olleolleolle
olleolleolle approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful clarification, thank you @tijmenb! 🎉

@olleolleolle olleolleolle merged commit 95667f8 into lostisland:master Oct 26, 2020
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tijmenb @olleolleolle