docs: Adapters, how to create them #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
reviewed
Oct 22, 2020
docs/adapters/index.md
Outdated
|
|
||
| The rest of this text is about methods which make the authoring easier. | ||
|
|
||
| ### Helpful class: `::Faraday::Adapter` |
There was a problem hiding this comment.
Subclassing Faraday::Adapter is also necessary to access save_response and to be recognised as an adapter by the rack builder, so I'd make that a requirement.
iMacTia
reviewed
Oct 22, 2020
There was a problem hiding this comment.
Great work @olleolleolle 👏
I've just added a small comment and I agree with you that the parallel manager can probably be moved into another page as it's quite an advanced and long topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to explain what it takes to make a Faraday adapter, we're adding some guide text to the page on Adapters.
It's been a while since we added the website, but now could be the time to add a little more explanation.
Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Please, add more notes as comments on this PR, we need it.