Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci: ruby 2.7 #1100

Merged
merged 6 commits into from
Dec 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: [2.4.x, 2.5.x, 2.6.x]
ruby: ['2.4', '2.5', '2.6', '2.7']

steps:
- uses: actions/checkout@v1
Expand All @@ -47,27 +47,36 @@ jobs:
run: |
sudo apt-get install libcurl4-openssl-dev

- name: Set up RVM
run: |
curl -sSL https://get.rvm.io | bash

- name: Set up Ruby
uses: actions/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
run: |
source $HOME/.rvm/scripts/rvm
rvm install ${{ matrix.ruby }} --disable-binary
rvm --default use ${{ matrix.ruby }}

- name: Build
run: |
gem install bundler
source $HOME/.rvm/scripts/rvm
sudo apt-get install libcurl4-openssl-dev
gem install bundler -v '<2'
bundle install --jobs 4 --retry 3

- name: Setup Code Climate
if: matrix.ruby == '2.6.x'
if: matrix.ruby == '2.6'
run: |
curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
chmod +x ./cc-test-reporter
./cc-test-reporter before-build

- name: Test
run: bundle exec rake
run: |
source $HOME/.rvm/scripts/rvm
bundle exec rake

- name: Run Code Climate Test Reporter
if: success() && matrix.ruby == '2.6.x'
if: success() && matrix.ruby == '2.6'
run: ./cc-test-reporter after-build --coverage-input-type simplecov --exit-code $?
continue-on-error: true
2 changes: 1 addition & 1 deletion lib/faraday/adapter/net_http_persistent.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def net_http_connection(env)
if @connection_options.key?(:pool_size)
options[:pool_size] = @connection_options[:pool_size]
end
Net::HTTP::Persistent.new(options)
Net::HTTP::Persistent.new(**options)
else
Net::HTTP::Persistent.new('Faraday')
end
Expand Down