Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error initializer consistency #1095

Merged
merged 8 commits into from
Dec 31, 2019
Merged

improve error initializer consistency #1095

merged 8 commits into from
Dec 31, 2019

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Dec 27, 2019 •
edited
Loading

This brings over the changes to Error initialization and the specs from #1094.

  • Apply updated specs and fixes
  • Ensure all error constructors are consistent
  • Remove deprecation warnings

@technoweenie technoweenie mentioned this pull request Dec 27, 2019
Closed
5 tasks
iMacTia
iMacTia reviewed Dec 27, 2019
View reviewed changes
lib/faraday/error.rb Outdated Show resolved Hide resolved
iMacTia
iMacTia reviewed Dec 27, 2019
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an upstream port of the 0.1x fixes, however I think some of them can be removed from master as we only support Ruby 2.4+

@technoweenie technoweenie mentioned this pull request Dec 30, 2019
Merged
8 tasks
olleolleolle
olleolleolle approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of the conservative change re the arguments for the exception.

The whole change brings us to a place of rest with the error initialisation.

@technoweenie technoweenie merged commit 688d570 into master Dec 31, 2019
@technoweenie technoweenie deleted the upstream-error-init branch December 31, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technoweenie @olleolleolle @iMacTia