Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feedback #1

Open
jscaetano opened this issue Jun 21, 2022 · 3 comments
Open

Some feedback #1

jscaetano opened this issue Jun 21, 2022 · 3 comments

Comments

@jscaetano
Copy link

Nice code but it got some errors.

If i have a hand of say As Ac, pre-flop, with say, 6 players, the odds of having a pair show up as 0.357, shouldnt it be 1.000? given the fact that i already have a pair in hand? and the odds of having two pairs is 0.359, so it is more probable of having two pairs than one, if already have one? that is not right.

Also, in the same example, hand of As Ac, post-flop, being the flop Ah Ks Tc for example, i have a three of a kind, but the odds of having three of a kind show up as 0.612, once again, shouldnt it be 1.000?

But if i have a hand of As Ac, and the flop is Ah Ad Ks, the four of a kind odd is 1.000, in that case is right.

That was the only mistake i found on this code. if i find more I'll submit another issue. Looking forward for the fix :) thanks :)

@lostella
Copy link
Owner

lostella commented Jun 21, 2022

If i have a hand of say As Ac, pre-flop, with say, 6 players, the odds of having a pair show up as 0.357, shouldnt it be 1.000?

I don’t think so, with a pair in hand you might as well end up with a three- or four-of-kind, as well as other things.

(I’m not saying 0.357 is necessarily correct, but 1.000 is not)

@jscaetano
Copy link
Author

jscaetano commented Jun 22, 2022 via email

@jscaetano
Copy link
Author

jscaetano commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants