Merged
Conversation
Co-authored-by: Michal Sojka <michal.sojka@cvut.cz>
This will be needed for zenoh-cpp-vendor. See the next commit.
Their build system is quite involved. They call cargo internally from a build.rs script (which is built and executed by another cargo). The internal cargo compiles opaque-types crate and the compilation is supposed to fail. The build.rs script then parses the error messages and generates some code from them for later compilation stages. The opaque-types crate has different dependencies than the main zenoh-c crate and the tricky part was to ensure that the internal cargo sees different vendored dependencies than the top-level cargo.
Closed
Contributor
|
@wentasah this will need something like the following for cross support: |
Collaborator
Author
|
Hmm, I see. But this would probably require NixOS/nixpkgs@112d13c, which is not in nixpkgs we use now. Moving to current nixpkgs-unstable breaks quite a lot of things and I want to work on that in few weeks after I cleanup the repo a bit (getting rid of noetic, etc.). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of commits, which finally fixes build of
zenoh_cpp_vendor. This is important, because manykiltedpackages depend on it.This took inspiration from #558, cleaned up few things and added changes required for the current Zenoh version.