Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: handle err on db/migration count diff #6

Merged
merged 1 commit into from
Jun 19, 2019
Merged

*: handle err on db/migration count diff #6

merged 1 commit into from
Jun 19, 2019

Conversation

lopezator
Copy link
Owner

  • handle error on db/migration count diff.
  • expose ports on docker-compose for easier testing.
  • improve test coverage.

@codecov-io
Copy link

codecov-io commented Jun 19, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #6 into master will decrease coverage by 1.26%.
The diff coverage is 64.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   84.12%   82.85%   -1.27%     
==========================================
  Files           1        1              
  Lines          63       70       +7     
==========================================
+ Hits           53       58       +5     
- Misses          5        6       +1     
- Partials        5        6       +1
Impacted Files Coverage Δ
migrator.go 82.85% <64.7%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c957406...692e430. Read the comment docs.

@lopezator lopezator force-pushed the feature/misc branch 5 times, most recently from 583cbee to 36d8cf1 Compare June 19, 2019 14:11
@lopezator
*: handle err on db/migration count diff
692e430 
* handle error on db/migration count diff.
* expose ports on docker-compose for easier testing.
* improve test coverage.
@lopezator lopezator merged commit 5f0120b into master Jun 19, 2019
@lopezator lopezator deleted the feature/misc branch July 10, 2019 08:31
lopezator added a commit that referenced this pull request Apr 9, 2020
@lopezator
logger: implement logger option
a88005b 
Add a logger interface, a loggerfunc and WithLogger migrator option.

This would enable:

- Customizing/Disabling stdout output
- Integrating a 3rd party structured logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 9, 2020
@lopezator
logger: implement logger option
43e914b 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
@lopezator lopezator mentioned this pull request Apr 9, 2020
Merged
lopezator added a commit that referenced this pull request Apr 9, 2020
@lopezator
logger: implement logger option
3d96140 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 9, 2020
@lopezator
logger: implement logger option
2884ffb 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 9, 2020
@lopezator
logger: implement logger option
88a8df6 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 9, 2020
@lopezator
logger: implement logger option
ec0aac6 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 10, 2020
@lopezator
logger: implement logger option
dd66788 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 10, 2020
@lopezator
logger: implement logger option
38a88a3 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
lopezator added a commit that referenced this pull request Apr 10, 2020
@lopezator
logger: implement logger option
bee4efd 
Add a Logger interface, along with a LoggerFunc and a new WithLogger option.

This would enable:

- Customizing migrator output
- Integrating a 3rd party logging tool

By default, migrator will work as before, just outputting to stdout.

Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lopezator @codecov-io