Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme: add strict parameter to check and isValid #40

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update readme: add strict parameter to check and isValid #40

merged 2 commits into from
Jun 7, 2024

Conversation

ortegafernando
Copy link
Contributor

@ortegafernando ortegafernando commented Jun 6, 2024 •
edited by drupol
Loading

I hope you like the way I have written it. Thanks

Follow up of #39

@ortegafernando ortegafernando requested a review from lekoala as a code owner June 6, 2024 20:24
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jun 6, 2024

PR Summary

  • Addition of new section: Strict mode TIN number validation
    This update introduces a new section in the application manual. This part focuses on the validation of Tax Identification Numbers (TIN) employing a strict mode method. Users can learn how to utilize strict mode for a more stringent and accurate TIN validation process, improving data reliability.

drupol
drupol reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

README.md Outdated Show resolved Hide resolved
@ortegafernando
Copy link
Contributor Author

How about this?

Better, yes. You rock.

@drupol
Copy link
Contributor

drupol commented Jun 7, 2024

Can you please fix the prettier formatting issue?

@ortegafernando
Copy link
Contributor Author

Can you please fix the prettier formatting issue?
I'm sorry, I dont know how to do "Prettier to fix"

@drupol drupol merged commit 320da65 into loophp:master Jun 7, 2024
1 check failed
@drupol
Copy link
Contributor

drupol commented Jun 7, 2024

Thanks for your contribution, I'll fix the prettier stuff.

If you know companies that might be willing to sponsor our work, please feel free to sponsor Thomas or me on Github, it would definitely be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@lekoala lekoala Awaiting requested review from lekoala lekoala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ortegafernando @drupol