This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
fix the detail for PC-relative relocations and add explanation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the BFD code (under review now), we have:
#define RELOCATE_CALC_PC32_HI20(relocation, pc) \
({ \
bfd_vma lo = (relocation) & ((bfd_vma)0xfff); \
pc = pc & (~(bfd_vma)0xfff); \
if (lo > 0x7ff) \
{ \
relocation += 0x1000; \
} \
relocation &= ~(bfd_vma)0xfff; \
relocation -= pc; \
})
#define RELOCATE_CALC_PC64_HI32(relocation, pc) \
({ \
bfd_vma lo = (relocation) & ((bfd_vma)0xfff); \
if (lo > 0x7ff) \
{ \
relocation -= 0x100000000; \
} \
relocation -= (pc & ~(bfd_vma)0xffffffff); \
})
Pay attention at `relocation += 0x1000` and `relocation -= 0x100000000`.
Currently our detailed description does not strictly match it.
This will puzzle the engineer implementing or reviewing the relocs for
other linkers (gold/lld/mold) and cause we criticized by the upstream
reviewers. Fix the pseudo-code in the "detail" column and add two
footnotes as explanation about why the additional operation is needed.
xen0n
approved these changes
Dec 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the BFD code (under review now), we have:
Pay attention at
relocation += 0x1000andrelocation -= 0x100000000.Currently our detailed description does not strictly match it.
This will puzzle the engineer implementing or reviewing the relocs for
other linkers (gold/lld/mold) and cause we criticized by the upstream
reviewers. Fix the pseudo-code in the "detail" column and add two
footnotes as explanation about why the additional operation is needed.