Move all emojis to the client. #6
Conversation
|
Doesn't work after a hot code reload. Need to seed the local collectoin again at that point. |
| "tags": [] | ||
| }, { | ||
| "emoji": "🚑", | ||
| "description": "ambulan |
There was a problem hiding this comment.
How come _collection? I can't find any references to it.
There was a problem hiding this comment.
Afaik it's the only way I know of to insert documents on the client only (and yes, it's a hack). But meteor seems to clear the collection when a hot code reload happens, so we need to repopulate it. I just can't find a hook for that. There is Meteor._onMigrate but that runs before the reload takes place. I want to know when a reload just happened.
There was a problem hiding this comment.
Gotcha. Looks good to me then!
Too bad about no post-action on a reload :/ Otherwise we could've stored away the collection's content just before a reload, and then re-seeding.
There was a problem hiding this comment.
https://github.com/meteor/meteor/blob/master/packages/reload/reload.js#L122
This will probably work.
There was a problem hiding this comment.
Ackschhtually, it looks like it does work as it is, even after a hot code push. I think I ran into another error that prevented the emojis from loading.
No description provided.