Raid1 rw mode #12
Closed
Raid1 rw mode #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamiaSan
force-pushed
the
raid1_rw_mode
branch
2 times, most recently
from
2770832 to
2dfd5b3
Compare
This was referenced Jun 19, 2023
Function raid_bdev_resume takes as input parameters also a function pointer and a context to be called at the end of the resume operation. If no callback should be called, NULL parameters can be passed. Signed-off-by: Damiano Cipriani <[email protected]>
This was
linked to
issues
Jul 21, 2023
Closed
The read and write permissions management has been implemented into raid bdev. All raid levels support read and write mode, which is the default. Raid1 also supports write only mode. Signed-off-by: Damiano Cipriani <[email protected]>
Refactored the code creating raid_bdev_module_get_min_operational and raid_bdev_is_mode_supported functions. Signed-off-by: Damiano Cipriani <[email protected]>
raid_bdev_write_superblock take an addtional cb_arg parameter that will be used by rpc that update the superblock after the superblock write operation. Signed-off-by: Damiano Cipriani <[email protected]>
Implemented a RPC to add a new base bdev to an existing raid bdev. This functionality handle a read/write mode for the base bdev too. Actually only raid1 supports adding a new base bdev. Signed-off-by: Damiano Cipriani <[email protected]>
Implemented unit test for adding a new base bdev to an existing raid bdev operation. Signed-off-by: Damiano Cipriani <[email protected]>
Raid base bdev set mode operation now updates raid bdev super block, if present. Signed-off-by: Damiano Cipriani <[email protected]>
Merged
|
With the introduction of external snapshot, the write only mode is no more necessary. So I close this PR and substitute it with a new one: #19 |
This was
unlinked from
issues
Aug 30, 2023
Closed
DamiaSan
pushed a commit
to DamiaSan/spdk
that referenced
this pull request
Mar 11, 2024
Ubsan with clang complains when using spdk_ioviter with more iters than declared in the array: iov.c:69:9: runtime error: index 3 out of bounds for type 'struct spdk_single_ioviter[2]' #0 0x5df709 in spdk_ioviter_firstv /home/vagrant/spdk_repo/spdk/lib/util/iov.c:69:9 longhorn#1 0x53780b in raid5f_xor_stripe /home/vagrant/spdk_repo/spdk/module/bdev/raid/raid5f.c:270:24 longhorn#2 0x531bd8 in raid5f_submit_write_request /home/vagrant/spdk_repo/spdk/module/bdev/raid/raid5f.c:520:2 longhorn#3 0x52a03a in raid5f_submit_rw_request /home/vagrant/spdk_repo/spdk/module/bdev/raid/raid5f.c:596:9 longhorn#4 0x548c17 in test_raid5f_write_request /home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut.c:550:2 longhorn#5 0x544e18 in test_raid5f_submit_rw_request /home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut.c:714:3 longhorn#6 0x553e61 in __test_raid5f_submit_full_stripe_write_request /home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut.c:878:3 longhorn#7 0x543f84 in run_for_each_raid5f_config /home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut.c:748:3 longhorn#8 0x527ac1 in test_raid5f_submit_full_stripe_write_request /home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut.c:885:2 longhorn#9 0x7f4a71a0960a (/usr/lib64/libcunit.so.1+0x460a) (BuildId: 9c82dd336cbccd99721651ac0a04435e746e0fc0) longhorn#10 0x7f4a71a09937 (/usr/lib64/libcunit.so.1+0x4937) (BuildId: 9c82dd336cbccd99721651ac0a04435e746e0fc0) longhorn#11 0x7f4a71a0a897 in CU_run_all_tests (/usr/lib64/libcunit.so.1+0x5897) (BuildId: 9c82dd336cbccd99721651ac0a04435e746e0fc0) longhorn#12 0x524fe8 in main /home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut.c:1006:2 longhorn#13 0x7f4a711d750f in __libc_start_call_main (/usr/lib64/libc.so.6+0x2750f) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) longhorn#14 0x7f4a711d75c8 in __libc_start_main@GLIBC_2.2.5 (/usr/lib64/libc.so.6+0x275c8) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) longhorn#15 0x4235b4 in _start (/home/vagrant/spdk_repo/spdk/test/unit/lib/bdev/raid/raid5f.c/raid5f_ut+0x4235b4) (BuildId: 028d075edd1a7cd17881fd678ef076adfdbac13d) Fix this by making iters a zero-length array and put it in a union with a two-element array to keep the default size for compatibility. Change-Id: I8573b015755e9986cdadbfa1705d269d51a7c2b7 Signed-off-by: Artur Paszkiewicz <[email protected]> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18402 Reviewed-by: Jim Harris <[email protected]> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <[email protected]> Reviewed-by: Shuhei Matsumoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request there are 2 main developments:
These are 2 of the 3 steps needed to implement online rebuilding