feat(replica_remove): cancel snapshot hash when the replica is removed in v1 #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcheng0922
force-pushed
the
issue-10294-disable-snapshot-hashing
branch
from
dfa8ef2 to
dfc5411
Compare
davidcheng0922
force-pushed
the
issue-10294-disable-snapshot-hashing
branch
from
dfc5411 to
1cc577d
Compare
derekbit
force-pushed
the
issue-10294-disable-snapshot-hashing
branch
from
1cc577d to
4117fdc
Compare
…d in v1 Signed-off-by: David Cheng <[email protected]>
davidcheng0922
force-pushed
the
issue-10294-disable-snapshot-hashing
branch
from
4117fdc to
a0b3c58
Compare
shuo-wu
reviewed
Nov 20, 2025
Contributor
shuo-wu
left a comment
shuo-wu
left a comment
There was a problem hiding this comment.
I am thinking if all replica processes would automatically (and blindly) try to stop hashing before removal, rather than the upper level asks them to do so manually.
Contributor
Author
Currently, we remove the files ( So, maybe we should move this behavior to instance-manager and stop the hashing at the same time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#10294
What this PR does / why we need it:
When removing the replica, stop all related snapshot hashing
Special notes for your reviewer:
Additional documentation or context