feat: update spdk dependencies #1049
Draft
+6
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
2 times, most recently
from
f332f35 to
69a3162
Compare
derekbit
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
69a3162 to
38e47b9
Compare
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
2 times, most recently
from
38e47b9 to
b7c231a
Compare
derekbit
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
b7c231a to
f2c2778
Compare
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
f2c2778 to
d06cae3
Compare
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
d06cae3 to
f4685d1
Compare
Author
|
@derekbit please let me know if there's anything left to do here |
Contributor
|
@yulken Hi, Caio. We need to update the code in https://github.com/longhorn/longhorn-spdk-engine first, then update |
Contributor
|
Besides, for this feature, we need to check if there is any similar check in the longhorn-manager repo as well. |
Author
|
Thanks @shuo-wu, I will do it. |
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
f4685d1 to
4649c71
Compare
Signed-off-by: Caio Torres <[email protected]>
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
4649c71 to
ab81068
Compare
yulken
commented
Oct 30, 2025
|
|
||
| toolchain go1.25.3 | ||
|
|
||
| replace github.com/longhorn/longhorn-spdk-engine => github.com/yulken/longhorn-spdk-engine v0.0.0-e05509dbff19ffa9b4b48ceb3831654c1e44f899 |
Author
yulken
changed the title
|
This pull request is now in conflict. Could you fix it @yulken? 🙏 |
Author
|
@derekbit Will the dependencies be automatically updated here too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9064
What this PR does / why we need it:
Updating explicit dependencies
Special notes for your reviewer:
Additional documentation or context