Skip to content

Commit

Permalink
Silence shellcheck warnings (RPi-Distro#279)
Browse files Browse the repository at this point in the history
* SC1091: the `config` file might not be present, which is normal.
* SC2086: Double quote to prevent globbing and word splitting.

Tested clean output using: `find -name "*.sh" -exec shellcheck -x {} \;`
  • Loading branch information
hhromic authored and XECDesign committed Apr 25, 2019
1 parent 042f769 commit 407663a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions build-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ fi
set -e

if [ -f config ]; then
# shellcheck disable=SC1091
source config
fi

Expand Down
4 changes: 2 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ if [[ ! "$FIRST_USER_NAME" =~ ^[a-z][-a-z0-9_]*$ ]]; then
exit 1
fi

if [[ -n "${APT_PROXY}" ]] && ! curl --silent ${APT_PROXY} >/dev/null ; then
echo "Could not reach APT_PROXY server:" ${APT_PROXY}
if [[ -n "${APT_PROXY}" ]] && ! curl --silent "${APT_PROXY}" >/dev/null ; then
echo "Could not reach APT_PROXY server: ${APT_PROXY}"
exit 1
fi

Expand Down

0 comments on commit 407663a

Please sign in to comment.