Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1556:Fix GithubProfileScraper test #1557

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Fixes #1556:Fix GithubProfileScraper test #1557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions test/org/loklak/api/search/GithubProfileScraperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public void githubProfileScraperOrgTest() {
String userName = "fossasia";
String userId = "6295529";
String location = "Singapore";
String specialLink = "http://fossasia.org";
String specialLink = "https://fossasia.org";

try {
ClientConnection connection = new ClientConnection(url);
Expand All @@ -46,11 +46,11 @@ public void githubProfileScraperOrgTest() {

Post fetchedProfile = githubScraper.scrapeGithub(profile, br);

assertEquals(fetchedProfile.getString("short_description"), shortDescription);
assertEquals(fetchedProfile.getString("user"), userName);
assertEquals(fetchedProfile.getString("user_id"), userId);
assertEquals(fetchedProfile.getString("location"), location);
assertEquals(fetchedProfile.getString("special_link"), specialLink);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see here, there are some indentation convention to leave a space after comma. Could you add the space after comma in new changes please!!

assertEquals(shortDescription, fetchedProfile.getString("short_description"));
assertEquals(userName, fetchedProfile.getString("user"));
assertEquals(userId, fetchedProfile.getString("user_id"));
assertEquals(location, fetchedProfile.getString("location"));
assertEquals(specialLink, fetchedProfile.getString("special_link"));

}

Expand Down Expand Up @@ -81,10 +81,10 @@ public void githubProfileScraperUserTest() {

Post fetchedProfile = githubScraper.scrapeGithub(profile, br);

assertEquals(fetchedProfile.getString("user"), userName);
assertEquals(fetchedProfile.getString("full_name"), fullName);
assertEquals(fetchedProfile.getString("special_link"), specialLink);
assertEquals(fetchedProfile.getString("user_id"), userId);
assertEquals(userName, fetchedProfile.getString("user"));
assertEquals(fullName, fetchedProfile.getString("full_name"));
assertEquals(specialLink, fetchedProfile.getString("special_link"));
assertEquals(userId, fetchedProfile.getString("user_id"));
}

}