Bump version of VSCode used in tests #911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The i18n-ally tests are failing, since the
source.vue
files are being given the language identifier ofplaintext
(the default for unknown languages).There is an override in
test/fixtures/vue/.vscode/settings.json
, but that is ignored unlessvue
is a known identifier.Previously,
i18n-ally
used thejohnsoncodehk.volar
extension to add recognition of thevue
language identifier. At some point,johnsoncodehk.volar
was renamed tovue.volar
. Butvue.volar
cannot be installed on VSCode v1.52.0:What approach did you choose and why?
The most straightforward fix is to bump the version of VSCode used in the tests to a more modern one.
What should reviewers focus on?
These tests wil break once again in the future if/when
vue.volar
can no longer be installed on v1.77. But I don't have a nicer solution at this time.Other options include:
vue
identifier, and use thati18n-ally
itself register thevue
identifierThe impact of these changes
CI will pass again. 🙌