refactor: error reporting #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
loichyan
added a commit
that referenced
this pull request
Jul 13, 2024
Source paths have disappeared since #21, this PR adds them back.
Merged
loichyan
added a commit
that referenced
this pull request
Jul 14, 2024
### ✨ Overview This release mainly addresses the high memory usage issue reported in #18: fixed a potential memory leak (#21) and implemented stream processing (#22). Also, some UI changes were introduced in #21, as we switched the diagnostic reporter from [codespan_reporting](https://docs.rs/codespan-reporting/latest/codespan_reporting) to [miette](https://docs.rs/miette/latest/miette). ### 🚀 Features - **(runtime)** Set exact file size limit - **(runtime)** Add file limitation - **(runtime)** Filter out binary files ### 🐛 Bug Fixes - **(cli)** Report the source path of diagnostics (#23) - **(cli)** Subtract with overflow ### 🚜 Refactor - **(runtime)** Implement stream processing - **(runtime)** Zero-copy diagnostics reporting - Replace `codespan-reporting` with `miette` - **(util)** Rename `tryb!` to `try!` ### 📚 Documentation - **(readme)** Update badge URLs ### 🎨 Styling - Format with prettier - Make nightly rustfmt compatible with the stable rustfmt - Format with nightly rustfmt ### ⚙️ Miscellaneous Tasks - Generate UTC release date - Report Cargo check results - Rewrite - Fix typos - Fix typos - Update author name - Add checks (#17) ### 🛠️ Build - **(nix)** Update flakes - **(cargo)** Update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use miette to report diagnostics, as codespan_reporting has not been actively maintained for a while. This should also fix #18: Currently, all checked files are persisted in the memory (check here), leading to memory leaks.
This PR also introduces binary files filtering, which significantly reduces "Invalid UTF-8" errors.