update to new event api #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming this is part of elastic/logstash#5227 ? |
|
@jrgns it is indeed. We plan on sending out an announcement about these upcoming changes shortly |
|
LGTM |
|
Ok. Should we be concerned about it breaking compatibility? Will we be bumping the major version? |
|
@jrgns. Yes, this new API is only compatible with >= 5.x version of Logstash, so all plugins must be updated with these changes in order to be compatible with the next release of Logstash. We have tried to do the work on most of the plugins in the does that sound OK? Please let me know if you have any other concerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.