use plugin.stop to return from run #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
| @@ -47,23 +47,28 @@ def run(queue) | |||
| @wmi = WIN32OLE.connect("winmgmts://") | |||
|
|
|||
| begin | |||
| @logger.debug("Executing WMI query '#{@query}'") | |||
| loop do | |||
| while !stop? | |||
There was a problem hiding this comment.
I have a slight preference for until stop? but to each his own :)
|
Couldn't test it (no windows box), but LGTM! |
| @logger.debug("Executing WMI query '#{@query}'") | ||
| loop do | ||
| while !stop? | ||
| @logger.debug("Executing WMI query '#{@query}'") |
There was a problem hiding this comment.
this should use structured logs, not string interpolation:
@logger.debug("Executing WMI query", :query => @query)
53 tasks
|
@jsvd just replying here as a reminder on this issue |
|
@jsvd just leaving you another reminder here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
stopto return fromrunaccording to elastic/logstash#3210Depends on elastic/logstash-devutils#32 and elastic/logstash#3895
resolves #10