Refactor shutdown behavior to follow the new pipeline semantic #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all traces of `Logstash::ShutdownSignal` and make sure we just get out of the loop as soon as possible. This PR also remove the `PATCH` for the `aws-sdk` which was needed when we were using the `Thread#raise`. Fixes #19
43 tasks
|
Ran (non-integration) specs. All tests pass! LGTM |
|
Merged sucessfully into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all traces of
Logstash::ShutdownSignaland make sure we just getout of the loop as soon as possible.
This PR also remove the
PATCHfor theaws-sdkwhich was needed whenwe were using the
Thread#raise.Fixes #19