support tcp transport protocol #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
jsvd
reviewed
Jun 1, 2018
lib/logstash/inputs/snmp.rb
Outdated
| @@ -76,16 +76,20 @@ def register | |||
|
|
|||
| host_details = host_name.match(HOST_REGEX) | |||
| raise(LogStash::ConfigurationError, "invalid format for host option '#{host_name}'") unless host_details | |||
| raise(LogStash::ConfigurationError, "only the udp protocol is supported for now") unless host_details[:host_protocol].to_s =~ /udp/i | |||
| raise(LogStash::ConfigurationError, "only udp & tcp protocols are supported") unless host_details[:host_protocol].to_s =~ /^(?:udp|tcp)$/i | |||
There was a problem hiding this comment.
like we do in the previous raise, here we should include the host string we're validating to help the user figure out where the mistake was.
| @@ -54,13 +54,15 @@ | |||
| {"get" => ["1.0"], "hosts" => [{"host" => "udp:localhost/161"}]}, | |||
| {"get" => ["1.0"], "hosts" => [{"host" => "udp:127.0.0.1/112345"}]}, | |||
| {"get" => ["1.0"], "hosts" => [{"host" => "udp:127.0.0.1/161", "community" => "public"}]}, | |||
| {"get" => ["1.0"], "hosts" => [{"host" => "tcp:127.0.0.1/112345"}]}, | |||
| {"get" => ["1.0"], "hosts" => [{"host" => "tcp:127.0.0.1/161", "community" => "public"}]}, | |||
There was a problem hiding this comment.
doesn't have to be - note that we are only verifying the format here but in any case, the port number can be any number.
There was a problem hiding this comment.
right, I was just aiming at consistency in the examples that reference 1161 for tcp in two other places.
add host info in exception
|
Thanks @jsvd ! will be pushing 0.1.0.beta3 shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for tcp transport protocol.
I locally tested this both for udp and tcp and both are working. We are lacking test/spec coverage for this and I will followup with an initial spec for the client.