fix database manager with multiple pipelines and expiry action#181
Merged
kaisecheng merged 24 commits intologstash-plugins:masterfrom Jun 15, 2021
Merged
Conversation
to prevent multiple download
kaisecheng
changed the title
…geoip into geoip_multiple_pipelines � Conflicts: � CHANGELOG.md � lib/logstash/filters/geoip.rb � logstash-filter-geoip.gemspec
18 tasks
…geoip into geoip_multiple_pipelines # Conflicts: # CHANGELOG.md # logstash-filter-geoip.gemspec
kaisecheng
commented
Jun 7, 2021
jsvd
reviewed
Jun 7, 2021
pin in logstash-core instead
jsvd
reviewed
Jun 8, 2021
jsvd
reviewed
Jun 8, 2021
jsvd
reviewed
Jun 9, 2021
jsvd
approved these changes
Jun 9, 2021
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
LGTM with a minor change to docs, as we don't yet mention anywhere the tagging of events in the case of an expired database.
remove the unwanted report of expiry message
…geoip into geoip_multiple_pipelines # Conflicts: # CHANGELOG.md # logstash-filter-geoip.gemspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes together with another Logstash PR elastic/logstash#12862
This PR does two things
_geoip_expired_databaseand bypass database lookup.Fixed: elastic/logstash#12856