Skip to content

Read-only file may be left in writable state #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sds83uk opened this issue Dec 23, 2021 · 1 comment
Closed

Read-only file may be left in writable state #211

sds83uk opened this issue Dec 23, 2021 · 1 comment
Assignees
Labels
bug Something isn't working patch released

Comments

@sds83uk
Copy link

sds83uk commented Dec 23, 2021

I added a comment to issue #167 to a few days ago, unfortunately a problem with my account meant that I couldn't highlight this further and the comment would not have been displayed on the issue at the time the "patch released" label was added and the issue closed.

I believe that when --fix is used a read-only file may be left writable if:

  1. The file is locked by other process.
  2. The file contains the CVE-2021-45105 vulnerability (requiring an upgrade)
  3. The file is backed up (after setWritable) and later restored
  4. The backup file cannot be truncated

NB: With release 2.5.0, similar edge cases may exist when attempting to --restore a read-only targetFile from a backup.

@xeraph xeraph added the bug Something isn't working label Dec 23, 2021
@xeraph xeraph self-assigned this Dec 23, 2021
@xeraph
Copy link
Contributor

xeraph commented Dec 26, 2021

@sds83uk Would you test v2.6.2? 7427988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch released
Projects
None yet
Development

No branches or pull requests

2 participants