Increase timeout: waiting longer for action server to become available#7
Merged
andriimaistruk merged 2 commits intohumblefrom Dec 19, 2022
Merged
Increase timeout: waiting longer for action server to become available#7andriimaistruk merged 2 commits intohumblefrom
andriimaistruk merged 2 commits intohumblefrom
Conversation
Author
|
the second change is about the exception error message, before it was using non-existent std::string constructor, now the exception message is correctly formed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tonynajjar did it before increasing from 1 second to 10 seconds, as it transpired from several daily system tests that
even 10 seconds are not enough, leading to a failed test with nav2 initialization failure. I am increasing it from 10s to 20s, and I see this change as not affecting operations, but rather decreasing false negatives for daily system test reports.