Skip to content

System tests fix#56

Merged
papertowel123 merged 10 commits intoironfrom
fix_system_tests
Jan 19, 2024
Merged

System tests fix#56
papertowel123 merged 10 commits intoironfrom
fix_system_tests

Conversation

@papertowel123
Copy link


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@papertowel123 papertowel123 self-assigned this Jan 19, 2024
getInput("robot_base_frame", robot_base_frame_);
getInput("xy_goal_tolerance", goal_reached_tol_);
getInput("yaw_goal_tolerance", goal_reached_tol_yaw_);
node_ = config().blackboard->get<rclcpp::Node::SharedPtr>("node");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this last line will cause trouble, do you do this anywhere else?

Copy link
Author

@papertowel123 papertowel123 Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in is_battery_low_condition.cpp, goal_reached_condition.cpp, distance_traveled_condition.cpp, time_expired_condition.cpp

Copy link

@sofiasemianchuk sofiasemianchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@papertowel123 papertowel123 merged commit 8d161c8 into iron Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants