Skip to content

Bring most galactic changes to humble#3

Merged
tonynajjar merged 11 commits intohumblefrom
humble-migration
Nov 15, 2022
Merged

Bring most galactic changes to humble#3
tonynajjar merged 11 commits intohumblefrom
humble-migration

Conversation

@tonynajjar
Copy link


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@tonynajjar
Copy link
Author

tonynajjar commented Oct 21, 2022

This PR still needs some work. These are the main features missing:

  • dock action
  • backup action changes
  • respawn after bond connection goes down

@andriimaistruk if you have time to support here I won't say no. I can onboard you.

FYI @jplapp

@tonynajjar
Copy link
Author

To avoid double work, I propose to not add the docking and back_up actions to Nav2 because anyway we want to implement these in our own repo. Here are the tickets for them:

https://lvserv01.logivations.com/browse/AMRFM-1988 (needs description modificatiion)
https://lvserv01.logivations.com/browse/AMRFM-3439

@tonynajjar
Copy link
Author

Btw please notice that this repo is a github fork and not our private navigation repo. FYI @andriimaistruk, @jplapp and I discussed to keep a public fork for Nav2 to make collaboration easier. Any code we wish to keep private will be implemented as a plugin in our private packages

@jplapp
Copy link

jplapp commented Oct 24, 2022

regarding DriveOnHeading - to keep the scope of the task, let's move the backup changes to humble. Then we can migrate the BTs to DriveOnHeading, plus modify driveOnHeading in a separate step.

Regarding the dock behavior, yes, let's add that to a new amr_behaviors package

* compatibility

* add UID
@tonynajjar
Copy link
Author

@jplapp @andriimaistruk could you quickly review this? I'm pretty sure we will discover more things during testing but I want to merge this to be able to use the "humble" branch in the other PRs

Copy link

@jplapp jplapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tonynajjar tonynajjar merged commit 34f9055 into humble Nov 15, 2022
@jplapp
Copy link

jplapp commented Nov 15, 2022

I think https://github.com/logivations/navigation/pull/424/files is supported in humble already, no need to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants