Bring most galactic changes to humble#3
Conversation
|
This PR still needs some work. These are the main features missing:
@andriimaistruk if you have time to support here I won't say no. I can onboard you. FYI @jplapp |
|
To avoid double work, I propose to not add the docking and back_up actions to Nav2 because anyway we want to implement these in our own repo. Here are the tickets for them: https://lvserv01.logivations.com/browse/AMRFM-1988 (needs description modificatiion) |
|
Btw please notice that this repo is a github fork and not our private navigation repo. FYI @andriimaistruk, @jplapp and I discussed to keep a public fork for Nav2 to make collaboration easier. Any code we wish to keep private will be implemented as a plugin in our private packages |
|
regarding DriveOnHeading - to keep the scope of the task, let's move the backup changes to humble. Then we can migrate the BTs to DriveOnHeading, plus modify driveOnHeading in a separate step. Regarding the dock behavior, yes, let's add that to a new amr_behaviors package |
* compatibility * add UID
|
@jplapp @andriimaistruk could you quickly review this? I'm pretty sure we will discover more things during testing but I want to merge this to be able to use the "humble" branch in the other PRs |
|
I think https://github.com/logivations/navigation/pull/424/files is supported in humble already, no need to add |
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: