Add-flag-to-not-send-goal-in-BTactionnode#13
Merged
tonynajjar merged 1 commit intohumblefrom Feb 28, 2023
Merged
Conversation
* Added a flag to not send goal in BtActionNode Signed-off-by: Owen Hooper <17ofh@queensu.ca> * Fixed cpplint and uncrustify issues. * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_node.hpp Signed-off-by: Owen Hooper <17ofh@queensu.ca> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit 8e7090b)
Author
|
This will allow to not send a goal from the on_tick() of our BT action nodes (e.g. if input validation fails). It's already on master, just backporting it in our fork |
Author
|
@jplapp @andriimaistruk merging as this is simply a backport but feel free to leave comments |
Author
|
FYI opened https://github.com/ros-planning/navigation2/pull/3431/files to enable in for BTServiceNode as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owen Hooper 17ofh@queensu.ca
Fixed cpplint and uncrustify issues.
Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_node.hpp
Signed-off-by: Owen Hooper 17ofh@queensu.ca
Co-authored-by: Steve Macenski stevenmacenski@gmail.com
(cherry picked from commit 8e7090b)
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: