-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to Timber.Tree #3
base: master
Are you sure you want to change the base?
Conversation
varshneyjayant
commented
Aug 12, 2015
- Timber.HollowTree was deprecated
- Added support for Appname
1. Timber.HollowTree was deprecated 2. Added support for Appname
@@ -193,7 +250,7 @@ private String toJson(Level level, String message, Throwable t, Object... args) | |||
* @param t throwable | |||
* @param args message formatting arguments | |||
*/ | |||
private void log(Level level, String message, Throwable t, Object... args) { | |||
private void log(int level, String message, Throwable t, Object... args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psquickitjayant why change from Level to int?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mostlyjason the new library Timber.Tree
takes int as parameter
@tony19 We have improved the usage of |
Removed extra code for |
Do you want a separate PR as feature update for |
updated comments. |
@@ -53,6 +54,43 @@ public LogglyTree(String token) { | |||
handler = new LogglyClient.Callback() { | |||
@Override | |||
public void success() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Document empty method body
What do we need to do to get a new version of Timber supported? I can take over this PR if necessary. |
@darren-kelinske-fivestars Please go ahead and raise a PR. Also, please directly contact the loggly github page. Thanks, Jayant. |