Fix forward subcommand bugs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kropptrevor
commented
Jul 19, 2024
kropptrevor
commented
- No longer starts server for the forward subcommand
- Forward no longer prints an error on EOF
- Logging statements can now be tested
There was a problem hiding this comment.
hey @kropptrevor thanks for the contribution. I left just one question but overall things look good 👍🏻
| return messages | ||
| } | ||
|
|
||
| func loggingValue(t *testing.T, logEntry string, field string) string { |
There was a problem hiding this comment.
@kropptrevor what is the reason you added these helper functions if you're just providing a msg string?
There was a problem hiding this comment.
The idea is that this code can be reused to test other logging fields. This is also why the stub is exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.