Enhanced chat input #1794
Enhanced chat input #1794
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -185,7 +181,7 @@ const ChatInput = forwardRef<{ focus: () => void }, ChatInputProps>( | |||
| // When autonomous agent is on, it handles all tools internally | |||
| if (!autonomousAgentToggle) { | |||
| if (vaultToggle) toolCalls.push("@vault"); | |||
| if (webToggle) toolCalls.push("@websearch"); | |||
| if (webToggle) toolCalls.push("@web-search"); | |||
There was a problem hiding this comment.
Bug: Identifier Change Causes Backend Integration Issues
The web search tool identifier was changed from @websearch to @web-search. This appears to be an unintentional change that could break backend integration if the system expects the original identifier, potentially causing the tool to fail.
|
|
||
| // Use Range for accurate positioning | ||
| const editorWindow = editor._window ?? window; | ||
|
|
There was a problem hiding this comment.
Bug: Plugin Accesses Private Lexical API
The NoteCommandPlugin.tsx and SlashCommandPlugin.tsx components access editor._window, which is a private Lexical property. Relying on this internal API makes the code fragile and susceptible to breaking changes in future Lexical versions.
Additional Locations (1)
@logancyang please hold on bugbot for now. The PR is not done yet |
Description by Korbit AI
What change is being made?
Introduce the Note Pill feature to the Lexical editor, enabling inline decorator nodes for note references and enhancing the chat input's functionality with a Lexical-based editor.
Why are these changes being made?
The changes aim to streamline note referencing within the editor, improve text editing around noted elements, and leverage the scalable architecture of Lexical for better maintainability and functionality enhancements like the new centralized pill deletion system, which ensures consistency across all note pill types. The integration aims to enhance the user experience by adding structured note references while maintaining performance and scalability.