Repository navigation
Aldo: a thread whose machine went to sleep mid-turn shows paused, not working; reconnect nudges no longer cut off a connection in progress - #185
Conversation
… working; reconnect nudges no longer cut off a connection in progress
- Sidebar: a thread whose machine is asleep (Aldo's read, unless this page is
connected to it) with a turn on is "Paused mid-turn: open it to carry on",
with those waiting on the user, rather than "Working" for hours. Aldo's
"paused" state (a newer Aldo) means the same.
- Home: "paused" needs the user ("Paused mid-turn"); it isn't a decision.
- Bringing a machine up, the 8-second "try again" nudge went to a connection
even while it was connecting: an attempt slower than that (a big thread's
first sync on a phone) was cut off and started over, again and again, and
one just connected was dropped. Now only a connection waiting to try again
is nudged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 508875ff8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "paused": | ||
| return "Paused mid-turn: open it to carry on"; |
There was a problem hiding this comment.
When the user has disabled Settings → preloading opened threads, this instruction is false: useAldoPreload computes enabled from settings.openedThreads and exits at preload.ts:110-117, so opening a cached paused thread never calls ensureAldoConnected and the turn remains paused. Paused mid-turn threads need to bypass that preload preference or offer an explicit resume action.
AGENTS.md reference: AGENTS.md:L73-L73
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in cfc7cf7. useAldoPreload wakes a thread whose machine went to sleep mid-turn when it's opened, whatever the preload setting, the same way it wakes a thread with nothing to show. Paused here means the directory has the machine asleep while a kept shell still says working or monitoring. So 'open it to carry on' holds with preloading off.
| const needsYou = boardFor(home.conversations, now).needsYou.filter( | ||
| (c) => !putAway(c, now) && needsYouKind(c) !== "paused", | ||
| ); |
There was a problem hiding this comment.
On the phone layout, excluding paused conversations from aldoDecisions also excludes them from the Agents-tab badge and header summary, because AldoHome.tsx:337 and AldoAgentsTab.tsx:75 use aldoDecisions(...).length as their waiting count. Thus a paused thread appears inside the “Waiting on you” section while the tab reports no waiting items; keep it out of the decision walkthrough, but calculate those counts from all needs-you items.
AGENTS.md reference: AGENTS.md:L67-L70
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in cfc7cf7. A new aldoWaitingCount adds the decisions and the paused threads that aren't put away. The phone's badge (AldoHome) and the Agents tab summary use it. The walkthrough still goes through decisions only.
| // Its machine went to sleep mid-turn: opening the thread wakes it to carry on. | ||
| if (c.state === "paused") return "paused"; |
There was a problem hiding this comment.
Returning paused as a needs-you kind sends it through UI branches that assume every truthy kind has a PendingForm: AldoPeek.tsx:208-214 renders a warning callout whose only content can be that form, while PendingForm returns null for paused, producing an empty bordered panel when the conversation has no summary; AldoLiveCard.tsx:163-166 similarly renders an empty container. Add paused-specific content/action or restrict those callouts to the form-backed kinds.
AGENTS.md reference: AGENTS.md:L67-L69
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in cfc7cf7. For a paused thread, PendingForm now shows 'Its machine went to sleep mid-turn.' with an 'Open to carry on' button. The callouts in the Peek and the live card are no longer empty.
| // Its machine went to sleep mid-turn: opening the thread wakes it to carry on. | ||
| if (c.state === "paused") return "paused"; |
There was a problem hiding this comment.
This recognizes only the newer literal state: "paused", not the state: "working", machine: "asleep" payload that the new sidebar test explicitly handles for older/stale Aldo reads. For that payload boardFor still places the conversation in working, so the Home board continues to show “Working now” indefinitely while the sidebar correctly says “Paused mid-turn”; use the same asleep/failed-machine predicate, with the same live-connection override, for Home classification.
AGENTS.md reference: AGENTS.md:L67-L70
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in cfc7cf7. A new isPausedMidTurn covers both Aldo's paused and an older read's working on a machine asleep or failed. needsYouKind, boardFor (paused leaves the working list), isStuck and aldoDecisions all use it. I left out the live-connection override on the home board: Aldo's read follows the directory within seconds of a wake, and threading the connection through every needsYouKind caller isn't worth it. The sidebar keeps the override, since its shells are live.
1 participant
This is the client half of logancsack/aldo's "Agents paused mid-turn stay paused, not 'working' forever".
Sidebar and home: "Paused mid-turn", not "Working" for hours
A thread whose machine went to sleep mid-turn kept its last shell, which says "working", so the sidebar showed it as working for 6–10 hours.
paused: "Paused mid-turn: open it to carry on", with a pause icon, grouped with the threads waiting on the user. Aldo's own"paused"state, from a newer Aldo, means the same.needsYouKindadds "Paused mid-turn". It isn't a decision: opening the thread resumes it, soaldoDecisionsleaves it out, matching Aldo's brief.Opening a thread took minutes: the nudge cut off the connection
While bringing a machine up,
ensureAldoConnected(andfollowAldoMachine) sentretryNowevery 8 seconds, whatever the connection was doing.RetryRequestedinterrupts a connection being established (that has its own 15-second deadline), and drops one already connected.Now only a connection that is waiting to try again gets a nudge (
wantsNudgereads the supervisor's own phase: notconnectingorconnected).Tested
tsgo --noEmitis clean.vp linthas no findings in the changed files.needsYouKindandaldoDecisions.The client pin is left to the "Client pin" routine.
🤖 Generated with Claude Code