Skip to content

Changed formatters to use configuration #444 #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2020
Merged

Changed formatters to use configuration #444 #2835

merged 1 commit into from
Feb 29, 2020

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented Feb 23, 2020 •
edited
Loading

Changed formatters to use configuration #444

@joachimmetz joachimmetz requested a review from rgayon February 23, 2020 10:33
@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Feb 23, 2020
This was referenced Feb 23, 2020
Merged
Merged
Merged
rgayon
rgayon approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@rgayon rgayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachimmetz joachimmetz added to merge Issue has been reviewed and can be merged when checks are complete and removed blocked Work cannot progress until another issue is resolved labels Feb 27, 2020
@joachimmetz joachimmetz merged commit bbff0a3 into log2timeline:master Feb 29, 2020
@joachimmetz joachimmetz deleted the formattercfg1 branch February 29, 2020 08:04
@joachimmetz joachimmetz removed the to merge Issue has been reviewed and can be merged when checks are complete label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgayon rgayon rgayon approved these changes

Assignees

@rgayon rgayon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joachimmetz @rgayon