Dl/navbar test #123
Merged
Dl/navbar test #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Stimulus Controller (dropdown_controller.js):
This introduces proper separation of concerns, moving the dropdown logic out of the HTML and into a dedicated JavaScript file.
It allows for more complex behavior and easier maintenance.
Updated application.js:
Added Stimulus initialization and controller registration.
Using stimulus-vite-helpers for easier controller registration.
Changes in application.html.erb:
Removed inline JavaScript.
Added Stimulus data attributes for the dropdown, connecting the HTML to the Stimulus controller.
Package updates:
Added @hotwired/stimulus, stimulus-vite-helpers, and vite-plugin-stimulus-hmr.
These packages provide the Stimulus framework and tools for better integration with Vite.
Updated vite.config.mts:
Added StimulusHMR plugin, which enables Hot Module Replacement for Stimulus controllers.
Key improvements:
Better organization: JavaScript logic is now in dedicated files instead of inline in the HTML.
Enhanced maintainability: Easier to update and extend functionality.
Improved development experience: Hot Module Replacement allows for faster development cycles.
Follows modern best practices: Aligns with current standards in Rails and JavaScript development.
Scalability: This structure makes it easier to add more interactive elements as your app grows.