[v0.22] Revert "bugfix: set allocatable resources to 0 when free capacity goes negative" | bugfix: use PodRequests helper function from k8s.io/kubectl for correct allocatable resource calculation #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from
maintov0.22Original PR Nr.: #2349
Backported Commits:
This reverts commit db1fd5c.
Original PR Description:
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5716
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would calculate allocatable resources inside the virtual cluster incorrectly when virtual cluster scheduler was enabled
What else do we need to know?
With this PR, we are updating the code to use the same utility function that kubectl uses for the resource calculation.